fix: use entered regtest deposit address - #669
Open
pwltr wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR changes the Blocktank regtest deposit form to normalize and submit its editable address rather than generating another address during submission.
Confidence Score: 4/5The asynchronous address overwrite should be fixed before merging because it can direct a deposit somewhere other than the address the user entered. The changed submission path trusts mutable address state while existing on-appear and refresh tasks can still replace that state after user input; the raw-versus-trimmed emptiness mismatch also permits an avoidable invalid submission. Files Needing Attention: Bitkit/Views/Settings/BlocktankRegtestView.swift
|
| Filename | Overview |
|---|---|
| Bitkit/Views/Settings/BlocktankRegtestView.swift | The form now submits its address field correctly in the ordinary case, but pending address-generation work can replace user input before submission, and whitespace-only input leaves the button incorrectly enabled. |
Reviews (1): Last reviewed commit: "fix: use entered regtest deposit address" | Re-trigger Greptile
pwltr
force-pushed
the
fix/regtest-deposit-address
branch
from
August 14, 2026 15:55
aa68f6d to
514c4be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Blocktank regtest deposit form so deposits are sent to the address shown in the address field instead of silently generating a new address for the current primary address type.
Details
depositAddressvalue when callingregtestDepositFundsVerification
swiftformatonBitkit/Views/Settings/BlocktankRegtestView.swiftxcodebuild -workspace Bitkit.xcodeproj/project.xcworkspace -scheme Bitkit -configuration Debug -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' ARCHS=arm64 ONLY_ACTIVE_ARCH=YES build