Avoid deploy timeouts when proxy autostop overlaps a Machine update - #5106
Closed
tomr-a5 wants to merge 6 commits into
Closed
Avoid deploy timeouts when proxy autostop overlaps a Machine update#5106tomr-a5 wants to merge 6 commits into
tomr-a5 wants to merge 6 commits into
Conversation
tomr-a5
force-pushed
the
tom/reconcile-canary-target-state
branch
from
August 21, 2026 18:46
6c67f9e to
3071d2a
Compare
tomr-a5
marked this pull request as ready for review
August 24, 2026 21:22
tomr-a5
force-pushed
the
tom/reconcile-canary-target-state
branch
from
August 25, 2026 17:09
cf438de to
0a73550
Compare
tomr-a5
marked this pull request as draft
August 25, 2026 22:43
Contributor
Author
|
After sitting with the changes above a little longer, I found a simpler way to keep the fix entirely in flyctl. Closing these three drafts and will get the smaller implementation up shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
When proxy autostop overlaps an in-place Machine update, flyd can intentionally leave the replacement stopped while flyctl waits for it to start. Flyctl now completes against that exact stopped replacement instead of timing out.
How:
Canary and rolling updates use the optional target returned by Flaps to wait for the exact replacement to become started or stopped. Started targets retain their smoke and health checks; stopped targets skip only checks that require a running Machine. Explicit
skip_launch, new creates, immediate and blue-green deployments, unknown targets, and older servers retain their existing behavior.Testing:
skip_launch, older-server fallback, retry-stable launch intent, and exact-instance waits.Related to:
Documentation