Update deprecated EXT_ITER option in test configs - #2866
Conversation
EXT_ITER was removed in SU2 v7 and replaced by ITER. These eight configs still used the old name and failed to parse. Values are unchanged; this is a rename only. All eight verified to run on current develop with a serial build.
|
While you're at it: I counted 42 instances of EXT_ITER in the Testcases subdirectory. |
Right none of them are regression-tested, which is why they've been able to rot. I checked every config containing EXT_ITER against serial_regression.py and parallel_regression.py and none are referenced. As you say, they'd fail immediately in CI otherwise. I swept all 42 locally (fixing EXT_ITER → ITER and running each with a short iteration cap). Breakdown: 8 run fine with just the rename , those are this PR. 24 are the hom_euler DG cases. They need REF_LENGTH_MOMENT → REF_LENGTH as well, but 21 then fail because the referenced mesh files don't exist in either repo, and 3 are unsteady so EXT_ITER maps to TIME_ITER/INNER_ITER rather than ITER. I left all of these alone since I can't verify them. The rest need individual fixes: further deprecated options (FROZEN_VISC, GEO_AXIS_STATIONS, SOLUTION_LIN_FILENAME), SOLVER= NAVIER_STOKES with a turbulence model set (should presumably be RANS), SOLVER= FLUID_STRUCTURE_INTERACTION which no longer exists, and a couple of Sutherland's-law validation errors. Happy to keep going on the fixable ones in follow-up PRs if that's useful I kept this one to the cases I could actually verify run. |
|
I think it makes more sense to look at these config files individually, get them working and then add them to the regression test. These might be relatively easy to fix: I don't think they test something exotic and you can visually inspect the result to see if it looks reasonable. I am not sure what the moving/setting onera cases are supposed to test, and for uncertainty quantification a more thorough test is needed to make sure it works as expected. |
2 participants
EXT_ITER was removed in SU2 v7 and replaced by ITER. These eight configs still used the old name and failed to parse. Values are unchanged; this is a rename only.
All eight verified to run on current develop with a serial build.
Proposed Changes
EXT_ITER was removed in SU2 v7 and replaced by ITER, but eight test configs still used the old name and fail to parse with a "invalid option name" error. This renames the option in each; iteration values are unchanged, so there's no behavioral change.
Files updated:
control_surface/inv_ONERAM6_moving.cfg
control_surface/inv_ONERAM6_setting.cfg
euler/CRM/inv_CRM_JST.cfg
euler/channel/inv_channel.cfg
navierstokes/naca0012/lam_NACA0012.cfg
rans/flatplate/turb_SST_flatplate.cfg
rans/s809/turb_S809.cfg
rans_uq/naca0012/turb_NACA0012_uq.cfg
All eight were run locally on current develop (serial build) and start and converge normally.
Two things I noticed while doing this, not addressed here , happy to open separate issues if useful:
Several other configs have further deprecated options (FROZEN_VISC, REF_LENGTH_MOMENT, GEO_AXIS_STATIONS, SOLUTION_LIN_FILENAME) and some have solver/turbulence-model settings that no longer validate.
The hom_euler test cases reference mesh files that don't appear to exist in either the SU2 or TestCases repos, so those can't be run or verified.
Related Work
None.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.