test: migrate math/base/special/ccis to ULP-based assertions - #14194
Merged
Conversation
Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/ccistest cases from relative-tolerance (EPS-scaleddelta/tol) comparisons to ULP-based assertions using@stdlib/assert/is-almost-same-value, per the RFC in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.js.pure_real.json,general_complex.json), confirmed deterministic across three consecutive local runs (including a build of the native addon vianode-gyp):test.js(pure JS implementation): 0 ULP for both the real and imaginary components, across both fixture sets (exact bit-for-bit match against the reference fixtures).test.native.js(native addon): 0 ULP for both the real and imaginary components, across both fixture sets (also an exact match).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
math/base/special/cciswere changed; no other packages were touched.make test TESTS_FILTER=".*/math/base/special/ccis/.*"passes (2018/2018 for bothtest.jsand the native addon build oftest.native.js), run three times to confirm determinism, andmake eslint-tests TESTS_FILTER=".*/math/base/special/ccis/.*"(the repo's test-specific ESLint config) is clean on both files.math/base/special/cexp, and the reference commit 121f2c0 linked from the RFC) to mirror the exact idiom, including using literal per-assertion ULP values (rather than a single named constant) since that matches the convention used across all merged conversions in this codebase to date.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written entirely by Claude Code (an automated, unattended session), including discovering the candidate package, checking for collisions with existing/prior ULP-migration PRs, studying prior-art conversions (e.g.
math/base/special/cexp), rewriting the test assertions, building the native addon locally to measure the native-implementation ULP threshold empirically, and verifying determinism across repeated runs. It is left as a draft specifically so a human can review it before it is considered for merge, given issue #11352 encourages contributors to author these migrations manually.@stdlib-js/reviewers
Generated by Claude Code