chore: clean-up - #13978
Merged
Merged
Conversation
Propagates fix from 4db26c0 ("docs: fix inconsistent JSDoc annotations") to sibling packages documenting a factory-produced PRNG with `@function` instead of `@name`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AQwLfUnMjo4hyfgxsZRg2
Propagates fixes from 8ef56c4 ("refactor: add `const` qualifiers") and ed2034b ("chore: fix C lint errors") to sibling packages whose C function signatures lack `const` qualifiers on read-only parameters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AQwLfUnMjo4hyfgxsZRg2
Propagates fix from 1935a5f ("chore: clean-up") to a sibling benchmark asserting a primitive boolean return value via `assert/is-boolean` instead of `assert/is-boolean` `isPrimitive`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AQwLfUnMjo4hyfgxsZRg2
Propagates fix from 51e6c83 ("docs: update note") to the sibling package with the same needlessly escaped closing bracket in its interval-range note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AQwLfUnMjo4hyfgxsZRg2
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 6, 2026 16:46
kgryte
approved these changes
Aug 6, 2026
random/base and ndarray/base/assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request propagates fixes merged to
developbetween 2026-08-05 and 2026-08-06 to sibling packages with the same defects.JSDoc
@function→@name(source: 4db26c0)4db26c0 fixed
@stdlib/random/base/chisquare's@function chisquaretag to@name chisquare, since the documented export is a factory-produced PRNG value, not a function declaration. This propagates the same fix to the three remaining outliers inrandom/base, bringing all 43 packages into consistency:@stdlib/random/base/minstd@stdlib/random/base/minstd-shuffle@stdlib/random/base/mt19937C
constqualifiers (sources: 8ef56c4, ed2034b)Applies the
constqualification from 8ef56c4 and ed2034b to the remaining sibling assert packages that lacked it. Every helper invoked by these functions already declaresconst-qualified parameters, so no downstream signature changes are required.@stdlib/ndarray/base/assert/is-buffer-length-compatible@stdlib/ndarray/base/assert/is-buffer-length-compatible-shape@stdlib/ndarray/base/assert/is-column-major-contiguousis-contiguousis excluded. PR #13874 already const-qualifies it.Benchmark boolean assertion (source: 1935a5f)
Propagates the fix from 1935a5f to
@stdlib/assert/deep-equal'sbenchmark/benchmark.js, replacingrequire( '@stdlib/assert/is-boolean' )withrequire( '@stdlib/assert/is-boolean' ).isPrimitive. The soleisBooleancall site checksdeepEqual's return value, which is always a primitive boolean.README escaped bracket (source: 51e6c83)
Propagates the same README cleanup to the
number2wordsREADME, the last remaining occurrence of the unnecessary escaped-bracket form in theuint64/basenamespace:\[`0`, `2^53-1`\]becomes\[`0`, `2^53-1`], matching the fix already applied tobigint2wordsin 51e6c83.Related Issues
No.
Questions
No.
Other
Validation performed per pattern: signatures were derived from the source commits and searched across the in-scope namespaces; two independent validation passes confirmed each defect in full-file context; an adaptation pass confirmed each patch is self-contained within its target package (all C helpers called by the modified functions already declare
const-qualified parameters, and no external callers reference the three C symbols); and a style-consistency pass confirmed each patch matches the merged precedents.Deliberately excluded:
ndarray/base/assert/is-contiguous(covered by open PR #13874); double-precisionpowusage in other*fpackage fixtures (intentional reference computations, not the 37facc3 defect);shape parameterdescriptions inrandom/base/*validators (all verified correct); and the remaining escaped-bracket occurrences repo-wide (literal regexp output and CLI-syntax contexts where the escape is intended).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated fix-propagation routine: candidate sites were located by pattern search over the last 24 hours of
developcommits, and every applied patch was confirmed by two independent validation passes plus adaptation and style-consistency passes before committing.@stdlib-js/reviewers
Generated by Claude Code