test: migrate math/base/special/asind to ULP-based testing - #13899
Conversation
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves a part of #11352.
Description
This pull request:
math/base/special/asindfrom relative tolerance testing to ULP (unit in the last place) difference testing, per the tracking issue.delta/tol-based tolerance checks intest/test.jsandtest/test.native.jswitht.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ), using@stdlib/assert/is-almost-same-value.absimport from both test files (theEPSimport is retained, as it is still used elsewhere in the tests for domain-boundary checks).2) was determined empirically: starting from a high bound (64) and lowering it until the minimum integer value that still passes over the full fixture set (6011 assertions across both the negative- and positive-value fixtures) was found. The test suite was run twice at this bound to confirm deterministic results.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which searched the repository for a candidate package, studied several already-merged conversions in the same tracking issue to mirror the exact idiom used, and empirically determined the minimum ULP bound by running the test suite locally.
@stdlib-js/reviewers
Generated by Claude Code