Skip to content

Improve multinode periodic error rate - #2523

Merged
RowanJohns merged 2 commits into
stackhpc/2026.1from
improve-multinode-error-rate
Aug 20, 2026
Merged

Improve multinode periodic error rate#2523
RowanJohns merged 2 commits into
stackhpc/2026.1from
improve-multinode-error-rate

Conversation

@RowanJohns

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ce341b54-a4f7-4312-990d-890b7a3d8f2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 608c59af-cc6e-4365-a0ed-a6c9854333a4

📥 Commits

Reviewing files that changed from the base of the PR and between 4e0feff and 8ec8986.

📒 Files selected for processing (1)
  • etc/kayobe/ansible/requirements.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: stackhpc/check
  • GitHub Check: Ansible 2.19 lint with Python 3.12
  • GitHub Check: Ansible 2.20 lint with Python 3.12
🔇 Additional comments (1)
etc/kayobe/ansible/requirements.yml (1)

10-10: LGTM!


📝 Walkthrough

Updated the stackhpc.hashicorp Ansible collection from version 2.8.2 to 2.9.0 to fix an OpenBao container error.

Walkthrough

The Ansible requirements update changes the stackhpc.hashicorp collection from version 2.8.2 to 2.9.0.

Changes

HashiCorp collection update

Layer / File(s) Summary
Update collection requirement
etc/kayobe/ansible/requirements.yml
The stackhpc.hashicorp collection requirement changes from 2.8.2 to 2.9.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8ec89

This localized dependency requirement change has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RowanJohns RowanJohns self-assigned this Aug 19, 2026
Without this, proxysql upgrade to Gazpacho will fail saying ERROR
MissingRequiredSource:
/var/lib/kolla/config_files/ca-certificates/root.crt file is not found
etc/kayobe/ansible/secret-store/secret-store-generate-internal-tls.yml #
@Alex-Welsh Alex-Welsh added waiting-author-response PR is waiting for the author to respond and removed waiting-review PR is waiting for a review labels Aug 20, 2026
@RowanJohns

RowanJohns commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

In draft state because not all errors have been fixed yet. Will mark as ready to review once I can deploy openstack on the multinode instance.

Note: I am using Rocky 10 for my multinode test environment.

@RowanJohns RowanJohns added waiting-review PR is waiting for a review and removed waiting-author-response PR is waiting for the author to respond labels Aug 20, 2026
@RowanJohns
RowanJohns marked this pull request as ready for review August 20, 2026 09:55
@RowanJohns
RowanJohns requested a review from a team as a code owner August 20, 2026 09:55
@RowanJohns

Copy link
Copy Markdown
Contributor Author

This branch bumps the hashicorp version to fix the openbao issues in the multinode periodic CI, and includes #2508 to fix the root.crt not existing issue. This should fix multinode CI for Rocky 10.

@RowanJohns
RowanJohns merged commit e9abece into stackhpc/2026.1 Aug 20, 2026
28 of 29 checks passed
@RowanJohns
RowanJohns deleted the improve-multinode-error-rate branch August 20, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants