Conversation
sbernauer
marked this pull request as ready for review
July 30, 2026 13:49
Member
|
Because we had it yesterday with OpenLineage: I believe it could make sense to add a "path" or "endpoint" field. Just in case DataHub is deployed behind some proxy. :// |
Member
Author
Good point! For consistency reasons with UIF and AuthenticationClass I went with |
Maleware
reviewed
Aug 4, 2026
Maleware
left a comment
Member
There was a problem hiding this comment.
Just two typos, thanks you! Test passes locally, thus LTGTM otherwise.
| } | ||
|
|
||
| /// Generates the trivial `From<Params> for ResourceInfoRequest` conversions, so each HTTP handler | ||
| /// can turn its deserialized query parameters into a [`ResourceInfoRequest`] via `.into()`. Adding a |
Member
There was a problem hiding this comment.
Suggested change
| /// can turn its deserialized query parameters into a [`ResourceInfoRequest`] via `.into()`. Adding a | |
| /// can turn its deserialized query parameters into a [`ResourceInfoRequest`] via `.from()`. Adding a |
| #[derive(Clone)] | ||
| struct AppState { | ||
| backend: Arc<ResolvedBackend>, | ||
| // Note: Although we might no talk JSON to the underlying backend, we always return JSON as a |
Member
There was a problem hiding this comment.
Suggested change
| // Note: Although we might no talk JSON to the underlying backend, we always return JSON as a | |
| // Note: Although we might not talk JSON to the underlying backend, we always return JSON as a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #848
Yes, the diff looks big, but most of it are lockfiles and kuttl tests
CRD change
Basically the same as for the user-info-fetcher. The only difference is the
envfield, which is DataHub specific.Look at
extra/crds.yamlfor the concrete CRD changeAPI of RIF
The rego rules and HTTP API of RIF: https://github.com/stackabletech/opa-operator/blob/spike/rif/docs/modules/opa/pages/usage-guide/resource-info-fetcher.adoc
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features trackerRelease notes
Added
For now only DataHub is supported.
Also, a rego-rule library has been added to make it easier to call resource-info-fetcher from within OPA.
The API (especially the response) might change in the future once more data catalogs are supported
Nightly docs
As soon as this PR is merged the docs will show up at https://docs.stackable.tech/home/nightly/opa/usage-guide/resource-info-fetcher/