Skip to content

fix(test): Don't tear down AirflowClusters when --skip-delete is used - #841

Merged
sbernauer merged 2 commits into
mainfrom
fix/test-teardowm
Aug 12, 2026
Merged

fix(test): Don't tear down AirflowClusters when --skip-delete is used#841
sbernauer merged 2 commits into
mainfrom
fix/test-teardowm

Conversation

@sbernauer

Copy link
Copy Markdown
Member

Description

I ran into this problem enough times to tell claude to fix it

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Aug 12, 2026
@sbernauer
sbernauer requested a review from adwk67 August 12, 2026 08:26
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 12, 2026

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked in detail, but if these steps are all identical, can they instead use a script in the commons folder, alongside health.py and metrics.py?

@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 12, 2026
@sbernauer

Copy link
Copy Markdown
Member Author

Good call, did so in ebb3239

@sbernauer sbernauer changed the title fix(test): Don't tear down AirflowClusters when --skip-delete is used fix(test): Don't tear down AirflowClusters when --skip-delete is used Aug 12, 2026

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for this!

@sbernauer
sbernauer added this pull request to the merge queue Aug 12, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 12, 2026
Merged via the queue into main with commit f08019d Aug 12, 2026
12 checks passed
@sbernauer
sbernauer deleted the fix/test-teardowm branch August 12, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants