Skip to content

[FME-17477] bump go-split-commons to v10 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alejovazquezsplit wants to merge 1 commit into
base: development
Choose a base branch
from
Open

[FME-17477] bump go-split-commons to v10 #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/gin-gonic/gin v1.10.1
github.com/google/uuid v1.3.0
github.com/splitio/gincache v1.0.1
github.com/splitio/go-split-commons/v9 v9.1.0
github.com/splitio/go-split-commons/v10 v10.0.0
github.com/splitio/go-toolkit/v5 v5.4.1
github.com/stretchr/testify v1.11.1
go.etcd.io/bbolt v1.3.6
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ github.com/rogpeppe/go-internal v1.8.0 h1:FCbCCtXNOY3UtUuHUYaghJg4y7Fd14rXifAYUA
github.com/rogpeppe/go-internal v1.8.0/go.mod h1:WmiCO8CzOY8rg0OYDC4/i/2WRWAB6poM+XZ2dLUbcbE=
github.com/splitio/gincache v1.0.1 h1:dLYdANY/BqH4KcUMCe/LluLyV5WtuE/LEdQWRE06IXU=
github.com/splitio/gincache v1.0.1/go.mod h1:CcgJDSM9Af75kyBH0724v55URVwMBuSj5x1eCWIOECY=
github.com/splitio/go-split-commons/v9 v9.1.0 h1:sfmPMuEDTtbIOJ+MeWNbfYl2/xKB/25d4/J95OUD+X0=
github.com/splitio/go-split-commons/v9 v9.1.0/go.mod h1:gJuaKo04Swlh4w9C1b2jBAqAdFxEd/Vpd8jnFINOeDY=
github.com/splitio/go-split-commons/v10 v10.0.0 h1:W2j9OJaghOzX9hI7hlrregLygAjF//JghY8VNvZEw3k=
github.com/splitio/go-split-commons/v10 v10.0.0/go.mod h1:/gEHK8JR4FudvLcAYp4gaMMejmzt1NKhap/0lIhjkIw=
github.com/splitio/go-toolkit/v5 v5.4.1 h1:srTyvDBJZMUcJ/KiiQDMyjCuELVgTBh2TGRVn0sOXEE=
github.com/splitio/go-toolkit/v5 v5.4.1/go.mod h1:SifzysrOVDbzMcOE8zjX02+FG5az4FrR3Us/i5SeStw=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
Expand Down
4 changes: 2 additions & 2 deletions splitio/admin/common/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package common

import (
"github.com/splitio/go-split-commons/v9/engine/grammar/constants"
"github.com/splitio/go-split-commons/v9/storage"
"github.com/splitio/go-split-commons/v10/engine/grammar/constants"
"github.com/splitio/go-split-commons/v10/storage"
)

var ProducerFeatureFlagsRules = []string{constants.MatcherTypeAllKeys, constants.MatcherTypeInSegment, constants.MatcherTypeWhitelist, constants.MatcherTypeEqualTo, constants.MatcherTypeGreaterThanOrEqualTo, constants.MatcherTypeLessThanOrEqualTo, constants.MatcherTypeBetween,
Expand Down
4 changes: 2 additions & 2 deletions splitio/admin/controllers/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"strings"
"time"

"github.com/splitio/go-split-commons/v9/storage"
"github.com/splitio/go-split-commons/v9/telemetry"
"github.com/splitio/go-split-commons/v10/storage"
"github.com/splitio/go-split-commons/v10/telemetry"

"github.com/splitio/split-synchronizer/v5/splitio/admin/views/dashboard"
"github.com/splitio/split-synchronizer/v5/splitio/producer/evcalc"
Expand Down
4 changes: 2 additions & 2 deletions splitio/admin/controllers/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (

"github.com/splitio/split-synchronizer/v5/splitio/admin/views/dashboard"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/storage/mocks"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/storage/mocks"
"github.com/splitio/go-toolkit/v5/datastructures/set"

"github.com/stretchr/testify/assert"
Expand Down
4 changes: 2 additions & 2 deletions splitio/admin/controllers/observability_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
"github.com/splitio/split-synchronizer/v5/splitio/provisional/observability"
"github.com/splitio/split-synchronizer/v5/splitio/proxy/storage"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/storage/mocks"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/storage/mocks"
"github.com/splitio/go-toolkit/v5/datastructures/set"
"github.com/splitio/go-toolkit/v5/logging"

Expand Down
2 changes: 1 addition & 1 deletion splitio/common/conf/advanced.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package conf
import (
"os"

"github.com/splitio/go-split-commons/v9/conf"
"github.com/splitio/go-split-commons/v10/conf"
)

// InitAdvancedOptions initializes an advanced config with default values + overriden urls.
Expand Down
2 changes: 1 addition & 1 deletion splitio/common/conf/validators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package conf
import (
"strings"

"github.com/splitio/go-split-commons/v9/flagsets"
"github.com/splitio/go-split-commons/v10/flagsets"
)

type FlagSetValidationError struct {
Expand Down
2 changes: 1 addition & 1 deletion splitio/common/conf/validators_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package conf
import (
"testing"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v10/dtos"

"github.com/stretchr/testify/assert"
)
Expand Down
2 changes: 1 addition & 1 deletion splitio/common/impressionlistener/listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"fmt"
"net/http"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-toolkit/v5/struct/traits/lifecycle"
)

Expand Down
2 changes: 1 addition & 1 deletion splitio/common/impressionlistener/listener_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"net/http/httptest"
"testing"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/stretchr/testify/assert"
)

Expand Down
2 changes: 1 addition & 1 deletion splitio/common/impressionlistener/mocks/listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"github.com/splitio/split-synchronizer/v5/splitio/common/impressionlistener"
"github.com/stretchr/testify/mock"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v10/dtos"
)

type ImpressionBulkListenerMock struct {
Expand Down
2 changes: 1 addition & 1 deletion splitio/common/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"github.com/splitio/split-synchronizer/v5/splitio/provisional/healthcheck/application"
"github.com/splitio/split-synchronizer/v5/splitio/provisional/healthcheck/services"

"github.com/splitio/go-split-commons/v9/synchronizer"
"github.com/splitio/go-split-commons/v10/synchronizer"
"github.com/splitio/go-toolkit/v5/logging"
"github.com/splitio/go-toolkit/v5/sync"
)
Expand Down
6 changes: 3 additions & 3 deletions splitio/common/sync/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package sync

import (
"github.com/splitio/go-split-commons/v9/conf"
"github.com/splitio/go-split-commons/v9/synchronizer"
"github.com/splitio/go-split-commons/v9/tasks"
"github.com/splitio/go-split-commons/v10/conf"
"github.com/splitio/go-split-commons/v10/synchronizer"
"github.com/splitio/go-split-commons/v10/tasks"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
2 changes: 1 addition & 1 deletion splitio/producer/conf/sections.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package conf
import (
"github.com/splitio/split-synchronizer/v5/splitio/common/conf"

cconf "github.com/splitio/go-split-commons/v9/conf"
cconf "github.com/splitio/go-split-commons/v10/conf"
)

// Main configuration options
Expand Down
30 changes: 15 additions & 15 deletions splitio/producer/initialization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,21 @@ import (
"github.com/splitio/split-synchronizer/v5/splitio/provisional/observability"
"github.com/splitio/split-synchronizer/v5/splitio/util"

cconf "github.com/splitio/go-split-commons/v9/conf"
"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/engine/grammar"
"github.com/splitio/go-split-commons/v9/flagsets"
"github.com/splitio/go-split-commons/v9/provisional/strategy"
"github.com/splitio/go-split-commons/v9/service/api"
"github.com/splitio/go-split-commons/v9/storage/filter"
"github.com/splitio/go-split-commons/v9/storage/inmemory"
"github.com/splitio/go-split-commons/v9/storage/redis"
"github.com/splitio/go-split-commons/v9/synchronizer"
"github.com/splitio/go-split-commons/v9/synchronizer/worker/impressionscount"
"github.com/splitio/go-split-commons/v9/synchronizer/worker/segment"
"github.com/splitio/go-split-commons/v9/synchronizer/worker/split"
"github.com/splitio/go-split-commons/v9/tasks"
"github.com/splitio/go-split-commons/v9/telemetry"
cconf "github.com/splitio/go-split-commons/v10/conf"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/engine/grammar"
"github.com/splitio/go-split-commons/v10/flagsets"
"github.com/splitio/go-split-commons/v10/provisional/strategy"
"github.com/splitio/go-split-commons/v10/service/api"
"github.com/splitio/go-split-commons/v10/storage/filter"
"github.com/splitio/go-split-commons/v10/storage/inmemory"
"github.com/splitio/go-split-commons/v10/storage/redis"
"github.com/splitio/go-split-commons/v10/synchronizer"
"github.com/splitio/go-split-commons/v10/synchronizer/worker/impressionscount"
"github.com/splitio/go-split-commons/v10/synchronizer/worker/segment"
"github.com/splitio/go-split-commons/v10/synchronizer/worker/split"
"github.com/splitio/go-split-commons/v10/tasks"
"github.com/splitio/go-split-commons/v10/telemetry"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
6 changes: 3 additions & 3 deletions splitio/producer/initialization_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ import (
"github.com/splitio/split-synchronizer/v5/splitio/producer/conf"
"github.com/splitio/split-synchronizer/v5/splitio/util"

config "github.com/splitio/go-split-commons/v9/conf"
"github.com/splitio/go-split-commons/v9/service/mocks"
predis "github.com/splitio/go-split-commons/v9/storage/redis"
config "github.com/splitio/go-split-commons/v10/conf"
"github.com/splitio/go-split-commons/v10/service/mocks"
predis "github.com/splitio/go-split-commons/v10/storage/redis"
"github.com/splitio/go-toolkit/v5/logging"

"github.com/stretchr/testify/mock"
Expand Down
2 changes: 1 addition & 1 deletion splitio/producer/storage/mocks/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package mocks

import (
"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v10/dtos"
)

// RedisTelemetryConsumerMultiMock is a mock
Expand Down
6 changes: 3 additions & 3 deletions splitio/producer/storage/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import (
"strconv"
"strings"

"github.com/splitio/go-split-commons/v9/dtos"
redisSt "github.com/splitio/go-split-commons/v9/storage/redis"
"github.com/splitio/go-split-commons/v9/telemetry"
"github.com/splitio/go-split-commons/v10/dtos"
redisSt "github.com/splitio/go-split-commons/v10/storage/redis"
"github.com/splitio/go-split-commons/v10/telemetry"
"github.com/splitio/go-toolkit/v5/logging"
"github.com/splitio/go-toolkit/v5/redis"
)
Expand Down
6 changes: 3 additions & 3 deletions splitio/producer/storage/telemetry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import (
"testing"
"time"

"github.com/splitio/go-split-commons/v9/dtos"
redisSt "github.com/splitio/go-split-commons/v9/storage/redis"
"github.com/splitio/go-split-commons/v9/telemetry"
"github.com/splitio/go-split-commons/v10/dtos"
redisSt "github.com/splitio/go-split-commons/v10/storage/redis"
"github.com/splitio/go-split-commons/v10/telemetry"
"github.com/splitio/go-toolkit/v5/logging"
"github.com/splitio/go-toolkit/v5/redis"
)
Expand Down
4 changes: 2 additions & 2 deletions splitio/producer/task/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (

"github.com/splitio/split-synchronizer/v5/splitio/producer/evcalc"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/storage"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/storage"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
4 changes: 2 additions & 2 deletions splitio/producer/task/events_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import (

"github.com/splitio/split-synchronizer/v5/splitio/producer/evcalc"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/storage/mocks"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/storage/mocks"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
12 changes: 6 additions & 6 deletions splitio/producer/task/impressions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import (
"github.com/splitio/split-synchronizer/v5/splitio/common/impressionlistener"
"github.com/splitio/split-synchronizer/v5/splitio/producer/evcalc"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/provisional"
"github.com/splitio/go-split-commons/v9/storage"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/provisional"
"github.com/splitio/go-split-commons/v10/storage"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down Expand Up @@ -252,14 +252,14 @@ func (s *impsWithMetadata) add(i *dtos.Impression) {
// TODO: Log? (this should not happen)
return
}
idx, ok := s.nindex[i.FeatureName]
idx, ok := s.nindex[i.DefinitionName]
if !ok {
s.imps = append(s.imps, dtos.ImpressionsDTO{
TestName: i.FeatureName,
TestName: i.DefinitionName,
KeyImpressions: s.pool.acquireKeyImpressions(),
})
idx = len(s.imps) - 1
s.nindex[i.FeatureName] = idx
s.nindex[i.DefinitionName] = idx
}
s.imps[idx].KeyImpressions = append(s.imps[idx].KeyImpressions, dtos.ImpressionDTO{
KeyName: i.KeyName,
Expand Down
20 changes: 10 additions & 10 deletions splitio/producer/task/impressions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ import (
"github.com/splitio/split-synchronizer/v5/splitio/producer/evcalc"
"github.com/splitio/split-synchronizer/v5/splitio/common/impressionlistener"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/provisional"
"github.com/splitio/go-split-commons/v9/provisional/strategy"
"github.com/splitio/go-split-commons/v9/storage/inmemory"
"github.com/splitio/go-split-commons/v9/storage/mocks"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/provisional"
"github.com/splitio/go-split-commons/v10/provisional/strategy"
"github.com/splitio/go-split-commons/v10/storage/inmemory"
"github.com/splitio/go-split-commons/v10/storage/mocks"
"github.com/splitio/go-toolkit/v5/logging"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
Expand Down Expand Up @@ -123,9 +123,9 @@ func makeSerializedImpressionsWithProperties(metadatas int, features int, keys i
feature := "feat_" + strconv.Itoa(findex)
for kindex := 0; kindex < keys; kindex++ {
imp := dtos.Impression{
FeatureName: feature,
KeyName: "key_" + strconv.Itoa(kindex),
Time: int64(1 + mindex*findex*kindex),
DefinitionName: feature,
KeyName: "key_" + strconv.Itoa(kindex),
Time: int64(1 + mindex*findex*kindex),
}
if withProperties {
imp.Properties = "{'prop':'val'}"
Expand Down Expand Up @@ -343,8 +343,8 @@ func TestSendImpressionsToListener(t *testing.T) {
MachineName: "test-machine",
},
Impression: dtos.Impression{
FeatureName: "test-feature",
KeyName: "test-key",
DefinitionName: "test-feature",
KeyName: "test-key",
Treatment: "on",
Time: 123,
Properties: "{'prop':'val'}",
Expand Down
6 changes: 3 additions & 3 deletions splitio/producer/task/uniquekeys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import (
"fmt"
"net/http"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/provisional/strategy"
"github.com/splitio/go-split-commons/v9/storage"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/provisional/strategy"
"github.com/splitio/go-split-commons/v10/storage"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
6 changes: 3 additions & 3 deletions splitio/producer/task/uniquekeys_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import (
"encoding/json"
"testing"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/provisional/strategy"
"github.com/splitio/go-split-commons/v9/storage/mocks"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/provisional/strategy"
"github.com/splitio/go-split-commons/v10/storage/mocks"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
12 changes: 6 additions & 6 deletions splitio/producer/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ import (
hcServicesCounter "github.com/splitio/split-synchronizer/v5/splitio/provisional/healthcheck/services/counter"
"github.com/splitio/split-synchronizer/v5/splitio/util"

config "github.com/splitio/go-split-commons/v9/conf"
"github.com/splitio/go-split-commons/v9/provisional"
"github.com/splitio/go-split-commons/v9/provisional/strategy"
"github.com/splitio/go-split-commons/v9/service"
storageCommon "github.com/splitio/go-split-commons/v9/storage"
"github.com/splitio/go-split-commons/v9/storage/redis"
config "github.com/splitio/go-split-commons/v10/conf"
"github.com/splitio/go-split-commons/v10/provisional"
"github.com/splitio/go-split-commons/v10/provisional/strategy"
"github.com/splitio/go-split-commons/v10/service"
storageCommon "github.com/splitio/go-split-commons/v10/storage"
"github.com/splitio/go-split-commons/v10/storage/redis"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
4 changes: 2 additions & 2 deletions splitio/producer/worker/impcounts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package worker

import (
"github.com/splitio/go-split-commons/v9/provisional/strategy"
"github.com/splitio/go-split-commons/v9/storage"
"github.com/splitio/go-split-commons/v10/provisional/strategy"
"github.com/splitio/go-split-commons/v10/storage"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
4 changes: 2 additions & 2 deletions splitio/producer/worker/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (

"github.com/splitio/split-synchronizer/v5/splitio/producer/storage"

"github.com/splitio/go-split-commons/v9/dtos"
"github.com/splitio/go-split-commons/v9/service"
"github.com/splitio/go-split-commons/v10/dtos"
"github.com/splitio/go-split-commons/v10/service"
"github.com/splitio/go-toolkit/v5/logging"
)

Expand Down
Loading