fix/security: block cross-host redirects - #1361
Merged
cbrnrd merged 2 commits intoAug 13, 2026
Merged
Conversation
cbrnrd
marked this pull request as ready for review
August 13, 2026 16:41
BolajiOlajide
approved these changes
Aug 13, 2026
…causes-oauth-bearer-token-exfiltration
cbrnrd
deleted the
carterbrainerd-vuln-114-cross-host-redirect-causes-oauth-bearer-token-exfiltration
branch
August 13, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The API client followed redirects to other hosts. These redirected requests could expose OAuth bearer tokens or custom auth-proxy headers to an untrusted server.
This addresses VULN-113 and VULN-114.
Solution
The API client now stops when a redirect points to a different host and returns the redirect response without following it. Redirects on the same host still work.
Regression tests cover OAuth tokens, custom auth-proxy headers, and same-host redirects.
Verification Evidence
go test ./internal/api -count=1go test -race ./internal/api -run 'Test(CredentialsAreNotSentOnCrossHostRedirect|ClientFollowsSameHostRedirect)$' -count=1