searcher: add autoCacheSize opt-in to auto-size disk cache - #917
Merged
Conversation
eseliger
approved these changes
Aug 6, 2026
Add a `searcher.autoCacheSize` flag (default false) that suppresses the hardcoded `SEARCHER_CACHE_SIZE_MB`/`SYMBOLS_CACHE_SIZE_MB` env vars. When enabled, searcher auto-sizes its cache to ~45% of the live cache volume, tracking PVC expansion instead of staying frozen to the initial storageSize. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
michaellzc
force-pushed
the
michaellzc/searcher-cache-optin-flag
branch
from
August 6, 2026 04:57
e53b03c to
ccb0243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
searcher.autoCacheSizeflag (defaultfalse) that, when enabled, omits the hardcodedSEARCHER_CACHE_SIZE_MB/SYMBOLS_CACHE_SIZE_MBenv vars sosearcherauto-sizes its cache to ~45% of the live cache volume. Today those env vars are frozen to the initialstorageSizeand never follow later PVC expansion, so instances whose searcher disks have been live-resized (e.g. to 2TiB) still use only ~11GB of cache; this flag lets the binary track the actual expanded disk. Existing instances are unaffected until they opt in. Also regenerates the chart README and adds a CHANGELOG entry.Checklist
Test plan
Rendered the searcher StatefulSet both ways with
helm template: default (autoCacheSize: false) still emitsSEARCHER_CACHE_SIZE_MB/SYMBOLS_CACHE_SIZE_MB("11700"), and--set searcher.autoCacheSize=trueomits both env vars while leavingCACHE_DIRintact. Confirmed./scripts/helm-docs.shproduces no further diff.🤖 Generated with Claude Code