docs: clarify Rust 1.89.0 requirement and add dependency-patch warning - #32
Open
Digitalenergyllc wants to merge 5 commits into
Open
docs: clarify Rust 1.89.0 requirement and add dependency-patch warning#32Digitalenergyllc wants to merge 5 commits into
Digitalenergyllc wants to merge 5 commits into
Conversation
Closes solana-foundation#22 The prerequisites listed Rust 1.89.0-dev without explaining why a nightly toolchain is required. Added context about jito-tip-router and Solana SDK nightly feature dependencies.
|
@Digitalenergyllc is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
…oting Closes solana-foundation#20 The troubleshooting section recommends commenting out code in jito-solana dependency crates without noting that these are fragile workarounds. Added a warning that they are for dev/testing only.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Closes #20
Summary
The NCN README pins Rust 1.89.0 as a prerequisite but doesn't explain why, and the troubleshooting section didn't warn that some workarounds modify dependency source code.
Changes
rustup overridetip to avoid changing the system defaultcargo update, and unsuitable for production (consolidated from docs: add warning about source-level dependency patches in troublesho… #33)