[Web] Fix delayTimeout type FlingGestureHandler - #4471
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe web fling gesture handler updates its private ChangesFling timeout typing
Merge Risk: ⚪ Minimal · up to This localized type-only fix is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Fixes a TypeScript typing inconsistency in the web implementation of FlingGestureHandler by updating its timeout field type to match the ReturnType<typeof setTimeout> approach introduced in #4381, improving compatibility for consumers whose TS programs include @types/node.
Changes:
- Update
FlingGestureHandler’sdelayTimeoutfield type fromnumbertoReturnType<typeof setTimeout>.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| private maxDurationMs = DEFAULT_MAX_DURATION_MS; | ||
| private minVelocity = DEFAULT_MIN_VELOCITY; | ||
| private delayTimeout!: number; | ||
| private delayTimeout!: ReturnType<typeof setTimeout>; | ||
|
|
Description
Leftover from #4381: the web handlers' timeout fields were changed to
ReturnType<typeof setTimeout>.FlingGestureHandlerwas the one that PR missed.Test plan
yarn ts-checkpasses