Handle remote HTTP errors - #61
Open
samuel-williams-shopify wants to merge 1 commit into
Open
Conversation
jakeonfire
approved these changes
Jul 30, 2026
jakeonfire
reviewed
Aug 7, 2026
| require "faraday/retry" | ||
|
|
||
| connection = Faraday.new(...) do |builder| | ||
| builder.request :retry, exceptions: [Faraday::ConnectionFailed] |
Contributor
There was a problem hiding this comment.
is this somewhat redundant with async-http's internal retries of socket failures? might this cause issues for PUT body streams that may have been drained? i have no qualms with the documentation, just trying to learn 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This demonstrates how the body error normalized by socketry/async-http#236 can participate in Faraday retry policy without adding hidden retries to the adapter. The original exception remains available through the Ruby exception cause chain.
Testing