fix(api): restore migrated endpoint and SDK compatibility - #6564
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryHigh Risk Overview Knowledge restores owner-only access to legacy personal knowledge bases (and their child resources) without weakening workspace-scoped auth, including usage admission, search billing, and shared audit projection. Tables again support unbounded filter updates/deletes via bounded keyset batches with concurrent-change revalidation, return missing rows as 404, preserve saved group output coordinates, and expose plan-derived Files switch nested write/move paths to canonical folder helpers with fail-fast segment limits and map folder/move conflicts to 409. Also restores legacy status codes for table name conflicts (400) and storage quota (402), strips encrypted service-account material from credential create responses, treats MCP paused HITL runs as successful tool results, allows nullable pause Reviewed by Cursor Bugbot for commit e0a5c39. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR restores API and SDK compatibility across error projection, file operations, table mutations, workflow execution, Knowledge authorization, and response serialization.
Confidence Score: 5/5The PR appears safe to merge because the previously reported issues are fixed and no blocking failure remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/rows/service.ts | Restores no-limit filter mutations using bounded keyset pages, per-page transactions, locked revalidation, and bounded side-effect dispatch. |
| packages/ts-sdk/src/index.ts | Restores synchronous execution failure throwing and compatibility fields for execution identifiers and timing metadata. |
| packages/ts-sdk/src/index.test.ts | Adds compiler-checked coverage for synchronous workflow failures and restored execution metadata. |
| apps/sim/app/api/credentials/route.ts | Validates credential-creation responses through the public contract so encrypted service-account material is omitted. |
| apps/sim/lib/workspace-files/application/workspace-file-folders.ts | Coordinates canonical nested-folder creation and rollback behavior for workspace-file operations. |
| apps/sim/lib/knowledge/application/authorization.ts | Restores legacy personal-knowledge owner access while preserving workspace-scoped authorization behavior. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Caller[API or SDK caller] --> Contract[Shared request/response contract]
Contract --> UseCase[Authorized application use case]
UseCase --> Domain[Files, Tables, Knowledge, or Workflows]
Domain --> Policy[Surface-specific error policy]
Policy --> Response[Legacy or v2 response envelope]
Reviews (8): Last reviewed commit: "fix(auth): project legacy knowledge audi..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9d7c60f. Configure here.
…r-projection # Conflicts: # apps/sim/app/api/mcp/servers/route.test.ts # apps/sim/app/api/mcp/servers/route.ts # apps/sim/app/api/table/utils.test.ts # apps/sim/app/api/v1/tables/route.test.ts # apps/sim/app/api/v2/files/folders/route.test.ts # apps/sim/app/api/v2/lib/response.ts # apps/sim/app/api/v2/tables/[tableId]/rows/[rowId]/route.test.ts # apps/sim/lib/api/contracts/workflows.ts # apps/sim/lib/uploads/archive.test.ts # apps/sim/lib/uploads/archive.ts # apps/sim/lib/uploads/contexts/workspace/workspace-file-folder-manager.test.ts # apps/sim/lib/uploads/contexts/workspace/workspace-file-folder-manager.ts # apps/sim/lib/workspace-files/application/workspace-file-folders.ts
TheodoreSpeaks
changed the title
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6976393. Configure here.
|
@cursor review |
…r-projection # Conflicts: # apps/sim/app/api/tools/file/manage/route.test.ts
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
2 issues from previous reviews remain unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1858bad. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e0a5c39. Configure here.
1 participant
Summary
executionId/ timing compatibility, and bump the SDK to 0.1.3Error model
Application and domain code now throws classified errors at the source. Shared route builders project those errors into each API surface's declared envelope, including typed
HttpErrorfailures. Unknown errors still fail closed as generic 500 responses without leaking implementation details.Security and authorization notes
Validation
Notes
stagingand includes staging through merge commit1858bad382(origin/stagingatcb2809001e)