feat(mship): mship sysprompt override - #6469
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Greptile SummaryThe PR adds an enterprise Mothership system-prompt override and completes its propagation through Sim, API-key validation, local deployment configurations, and Helm secret modes.
Confidence Score: 5/5The PR appears safe to merge because the previously reported Helm propagation failure is fixed and no blocking failure remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| helm/sim/values.yaml | Adds the prompt override to inline application values and External Secrets mappings; the generic secret templates propagate it into the pod. |
| helm/sim/tests/secret-modes_test.yaml | Covers inclusion and omission in inline mode and mapping in External Secrets mode. |
| apps/sim/lib/copilot/request/lifecycle/run.ts | Adds nonblank prompt overrides to outbound Mothership lifecycle payloads. |
| apps/sim/app/api/copilot/api-keys/validate/route.ts | Returns a server-derived enterprise entitlement for the validated API-key owner. |
| apps/sim/lib/api/contracts/copilot.ts | Updates the validation endpoint contract from an empty response to typed entitlement JSON. |
Sequence Diagram
sequenceDiagram
participant Operator
participant Helm as Helm / Deployment
participant Sim
participant Mship as Mothership
Operator->>Helm: Configure MSHIP_SYSPROMPT_OVERRIDE
Helm->>Sim: Inject value through app Secret
Sim->>Mship: Send lifecycle payload with systemPromptOverride
Mship->>Sim: Validate API-key owner
Sim-->>Mship: Return isEnterprise entitlement
Reviews (2): Last reviewed commit: "Validation improvements" | Re-trigger Greptile
|
@cursor review |
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit b53b6a6. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b53b6a6. Configure here.
Summary
Mship sysprompt override
Companion: https://github.com/simstudioai/mothership/pull/421
Type of Change
Testing
Manual
Checklist