Skip to content

Remove deuterocanon tests - #476

Open
Enkidu93 wants to merge 1 commit into
masterfrom
remove-deuterocanonicals-tests
Open

Remove deuterocanon tests#476
Enkidu93 wants to merge 1 commit into
masterfrom
remove-deuterocanonicals-tests

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes sillsdev/machine.py#174.

I didn't see any problems in the logging from the tests, so at least at this point, I think we've resolved any issues that these would have caught. The only problems I noticed were with the tests themselves.


This change is Reviewable

@Enkidu93
Enkidu93 requested a review from pmachapman August 14, 2026 20:45
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.31%. Comparing base (0b58830) to head (3987340).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   73.33%   73.31%   -0.03%     
==========================================
  Files         445      445              
  Lines       37317    37300      -17     
  Branches     5118     5115       -3     
==========================================
- Hits        27367    27346      -21     
- Misses       8825     8827       +2     
- Partials     1125     1127       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 32 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).


src/SIL.Machine/Corpora/ScrVersExtensions.cs line 11 at r1 (raw file):

        /// Gets a list of references (verse references) for the specified book.
        /// </summary>
        public static IEnumerable<VerseRef> GetReferencesForBook(this ScrVers scrVers, int bookNum)

If I understand correctly, you are removing this because it is not a part of machine.py? (as well as the fact it was only used by tests). I couldn't find any code on GitHub that use this method, but that doesn't mean that no one is necessarily using this function.

Code quote:

public static IEnumerable<VerseRef> GetReferencesForBook(this ScrVers scrVers, int bookNum)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add deuterocanon tests to machine.py

3 participants