Remove deuterocanon tests - #476
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 73.33% 73.31% -0.03%
==========================================
Files 445 445
Lines 37317 37300 -17
Branches 5118 5115 -3
==========================================
- Hits 27367 27346 -21
- Misses 8825 8827 +2
- Partials 1125 1127 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman reviewed 32 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).
src/SIL.Machine/Corpora/ScrVersExtensions.cs line 11 at r1 (raw file):
/// Gets a list of references (verse references) for the specified book. /// </summary> public static IEnumerable<VerseRef> GetReferencesForBook(this ScrVers scrVers, int bookNum)
If I understand correctly, you are removing this because it is not a part of machine.py? (as well as the fact it was only used by tests). I couldn't find any code on GitHub that use this method, but that doesn't mean that no one is necessarily using this function.
Code quote:
public static IEnumerable<VerseRef> GetReferencesForBook(this ScrVers scrVers, int bookNum)
Fixes sillsdev/machine.py#174.
I didn't see any problems in the logging from the tests, so at least at this point, I think we've resolved any issues that these would have caught. The only problems I noticed were with the tests themselves.
This change is