multi_encrypt: match padding entries to ciphertext size - #125
Merged
jagerman merged 1 commit intoAug 11, 2026
Merged
Conversation
Member
|
Nice catch & fix, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
when
padis enabled,encrypt_for_multiple_simple()currently sizes junk entries from the plaintext. real XChaCha20-Poly1305 ciphertexts include a 16-byte tag, so padding entries stay distinguishable by lengththis uses the encrypted size for padding entries, matching the existing C and C++ API docs. it also keeps padding enabled for empty messages, whose ciphertexts are still 16 bytes
tests
./build-pr/tests/testAll "[simple]"./build-pr/tests/testAllclang-format-19 --dry-run --Werror src/multi_encrypt.cpp tests/test_multi_encrypt.cpp