Skip to content

Backport release/v6.6: Tolerate failed Codex review executions - #3951

Merged
bdchatham merged 2 commits into
release/v6.6from
backport-3807-to-release/v6.6
Aug 19, 2026
Merged

Backport release/v6.6: Tolerate failed Codex review executions#3951
bdchatham merged 2 commits into
release/v6.6from
backport-3807-to-release/v6.6

Conversation

@seidroid

@seidroid seidroid Bot commented Aug 18, 2026

Copy link
Copy Markdown

Backport of #3807 to release/v6.6.

Codex failures previously terminated the shell before the existing
fallback review could be generated and posted to Slack. Handle failed
invocations as non-blocking so the workflow publishes its fallback
review instead.

(cherry picked from commit cc6d8ea)
@cursor

cursor Bot commented Aug 18, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only change to error handling around the Codex review step; no application, auth, or production runtime impact.

Overview
Makes the PR → Codex → Slack workflow keep going when the Codex CLI exits non-zero, instead of failing the whole job under set -euo pipefail.

Both Codex paths (embedded pr.diff and large-diff URL fallback) now run inside if ! ...; then handlers that log "Codex review failed; publishing fallback review." The large-diff branch also prints codex.log to stderr for debugging. Unchanged behavior still applies when review.md is missing or empty: the step writes Codex produced no output. so later Slack upload steps can run.

Backport of #3807 onto release/v6.6.

Reviewed by Cursor Bugbot for commit c7299b2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 18, 2026, 6:11 PM

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.12%. Comparing base (851cc6e) to head (c7299b2).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.6    #3951      +/-   ##
================================================
- Coverage         58.78%   58.12%   -0.66%     
================================================
  Files              2220     2151      -69     
  Lines            183137   174998    -8139     
================================================
- Hits             107649   101722    -5927     
+ Misses            65781    64235    -1546     
+ Partials           9707     9041     -666     
Flag Coverage Δ
sei-db 70.41% <ø> (?)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 110 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bdchatham
bdchatham requested review from amir-deris and masih August 18, 2026 17:49
@bdchatham
bdchatham enabled auto-merge (squash) August 18, 2026 17:51

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c7299b2. Configure here.

< prompt.txt \
> codex.log 2>&1; then
echo "Codex review failed; publishing fallback review." >&2
fi

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Codex failure log dump

Low Severity

The small-diff Codex failure handler redirects all output to codex.log but never prints it, unlike the large-diff handler which runs cat codex.log. Because failures are now non-fatal, the common path can succeed with only a generic message and no reason for the failure in the CI logs.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c7299b2. Configure here.

@bdchatham
bdchatham disabled auto-merge August 18, 2026 18:49
@bdchatham
bdchatham enabled auto-merge (squash) August 18, 2026 18:49
@bdchatham
bdchatham merged commit 97e2dad into release/v6.6 Aug 19, 2026
60 of 61 checks passed
@bdchatham
bdchatham deleted the backport-3807-to-release/v6.6 branch August 19, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants