Fix jvm_version parsing of non-numeric version suffixes - #92
Merged
Conversation
Split the version-string-to-tuple conversion out of jvm_version() into _jvm_version_str_to_tuple() and add unit tests.
The old regex captured the entire quoted version string, including non-numeric suffixes like "-internal" or "_312", which broke int() conversion downstream. Now only the leading dot-separated digit groups are captured. These examples now work as expected: * OpenJDK 11.0.9.1-internal -> (11, 0, 9, 1) * OpenJDK 1.8.0_312 -> (1, 8, 0)
Member
|
Awesome—thanks @ncittm! ✨ |
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
ctrueden
force-pushed
the
fix-jvm-version
branch
from
August 13, 2026 16:44
4b69fd7 to
9e20157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old regex captured the entire quoted version string, including
non-numeric suffixes like "-internal" or "_312", which broke int()
conversion downstream. Now only the leading dot-separated digit
groups are captured.
Extract jvm_version parsing into a testable helper function.
Closes #91.