Avoid false "Unable to bump version" when shared version val already bumped - #3944
Open
chris-huang-s wants to merge 2 commits into
Open
Conversation
Explain why PRs that bump a shared version val may list only one dependency, and point to grouping workarounds. Refs scala-steward-org#3780
When a later update finds a shared version variable already rewritten by an earlier update, log that the version is already bumped instead of warning. Refs scala-steward-org#3780
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3780 already has WIP PR #3852 covering the full grouping/description fix. This adjacent fix addresses related #2906 (misleading warning when multiple deps share a version variable) and documents the #3780 limitation in faq.md.
References #3780 and #2906.