Skip to content

Add incoming/outgoing direction to communications - #2177

Merged
maebeale merged 1 commit into
mainfrom
maebeale/comms-incoming-designation
Aug 13, 2026
Merged

Add incoming/outgoing direction to communications#2177
maebeale merged 1 commit into
mainfrom
maebeale/comms-incoming-designation

Conversation

@maebeale

@maebeale maebeale commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 5 Inspect 🔬 new column + backfill-safe migration, decorator/policy-adjacent logic, and wide comms UI changes

Goal

  • Communications could only be logged as messages sent to a person. This records whether one was incoming (sent by the person it's about) and surfaces at-a-glance context across the communications UI.

What changed

  • Direction — new direction string column (outgoing default, reversible migration) with an "Incoming" slider on the log forms; From/To flip for incoming.
  • Flags — chips for the exceptions only: sky Incoming, grey FYI (admin copy), indigo Bulk (bulk_payment). Regular person mail shows none. Recipient emails resolve to person names (email on hover) in To/From.
  • Index + detail theming — the communications index/detail use the notifications (sky) DomainTheme; a grey back eyebrow returns to the originating record (person/registration/etc.) or Admin home; comms-box rows click through to the detail (new tab, admin only).
  • Form tints — inline comment/communication log forms tinted with their domain colours.
  • Misc: "Edit registration" nav chip label.

Notes

  • Rebased onto latest main and squashed the incremental UI commits into one (several mutually reverted each other). Integrated cleanly with main's row_class/card_bg_class/archived? notification styling.
  • Bulk chip keys off the bulk_payment_* kinds; bulk reminders/invites carry no per-notification marker, so they aren't flagged (call out if you want a marker added).

Copilot AI lite review requested due to automatic review settings August 12, 2026 15:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 10:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 11:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 12:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 12:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 12:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 13, 2026 12:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maebeale
maebeale force-pushed the maebeale/comms-incoming-designation branch from 0b5b8ec to 3f7de1b Compare August 13, 2026 13:52
Copilot AI review requested due to automatic review settings August 13, 2026 13:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

- Record whether a communication is incoming (sent by the person it's about)
  via a direction slider on the log forms; default outgoing.
- Flag exceptions with chips on the index/detail/box: sky Incoming, grey FYI,
  indigo Bulk (bulk_payment); resolve recipient emails to person names with the
  email on hover in To/From.
- Theme the communications index and detail with the notifications colour, add a
  back eyebrow to the originating record, grey top eyebrows, and clickable
  comms-box rows (new tab).
- Tint the inline comment/communication log forms with their domain colours.
- Misc: rename the registration ticket's "Edit registration" chip.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@maebeale
maebeale force-pushed the maebeale/comms-incoming-designation branch from 3f7de1b to 73655c6 Compare August 13, 2026 13:57
Copilot AI review requested due to automatic review settings August 13, 2026 13:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maebeale
maebeale marked this pull request as ready for review August 13, 2026 13:59
@maebeale
maebeale merged commit ff3f817 into main Aug 13, 2026
3 checks passed
@maebeale
maebeale deleted the maebeale/comms-incoming-designation branch August 13, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants