Skip to content

Add submit-batch command and generate-json flags for multi-setting proposals - #1171

Open
0xfornax wants to merge 1 commit into
masterfrom
multi-setting-proposals
Open

Add submit-batch command and generate-json flags for multi-setting proposals#1171
0xfornax wants to merge 1 commit into
masterfrom
multi-setting-proposals

Conversation

@0xfornax

@0xfornax 0xfornax commented Aug 13, 2026

Copy link
Copy Markdown
Member

Closes #755

@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (3 decrease, 3 increase)

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/bindings/dao/protocol 0.00% (ø)
github.com/rocket-pool/smartnode/bindings/settings/protocol 0.55% (+0.55%) 👍
github.com/rocket-pool/smartnode/bindings/types 9.63% (-1.72%) 👎
github.com/rocket-pool/smartnode/bindings/utils/state 0.61% (-0.10%) 👎
github.com/rocket-pool/smartnode/rocketpool-cli/pdao 0.17% (+0.17%) 👍
github.com/rocket-pool/smartnode/rocketpool/api/pdao 0.09% (+0.09%) 👍
github.com/rocket-pool/smartnode/shared/services/rocketpool 0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/api 4.79% (-0.48%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/bindings/dao/protocol/proposal-payload.go 0.00% (ø) 841 (+841) 0 841 (+841)
github.com/rocket-pool/smartnode/bindings/dao/protocol/proposal.go 0.00% (ø) 4752 (+738) 0 4752 (+738)
github.com/rocket-pool/smartnode/bindings/settings/protocol/setting-types.go 20.00% (+20.00%) 195 (+195) 39 (+39) 156 (+156) 🎉
github.com/rocket-pool/smartnode/bindings/types/dao.go 0.00% (ø) 348 (+111) 0 348 (+111)
github.com/rocket-pool/smartnode/bindings/utils/state/pdao.go 0.00% (ø) 1477 (+220) 0 1477 (+220)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/commands.go 0.00% (ø) 11107 (+585) 0 11107 (+585)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/execute-proposal.go 0.00% (ø) 1346 (+65) 0 1346 (+65)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/proposals.go 0.00% (ø) 2700 (+636) 0 2700 (+636)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/propose-settings-json.go 8.06% (+8.06%) 893 (+893) 72 (+72) 821 (+821) 👍
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/propose-settings.go 0.00% (ø) 3810 (+159) 0 3810 (+159)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/set-allow-list.go 0.00% (ø) 1006 (+107) 0 1006 (+107)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/submit-batch.go 0.00% (ø) 938 (+938) 0 938 (+938)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/vote-proposal.go 0.00% (ø) 2032 (+142) 0 2032 (+142)
github.com/rocket-pool/smartnode/rocketpool/api/pdao/propose-settings-multi.go 0.00% (ø) 1906 (+1906) 0 1906 (+1906)
github.com/rocket-pool/smartnode/rocketpool/api/pdao/routes.go 0.00% (ø) 10672 (+1089) 0 10672 (+1089)
github.com/rocket-pool/smartnode/rocketpool/api/pdao/setting-decode.go 7.35% (+7.35%) 830 (+830) 61 (+61) 769 (+769) 👍
github.com/rocket-pool/smartnode/shared/services/rocketpool/pdao.go 0.00% (ø) 9916 (+1381) 0 9916 (+1381)
github.com/rocket-pool/smartnode/shared/types/api/pdao.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/bindings/dao/protocol/proposal-payload_test.go
  • github.com/rocket-pool/smartnode/rocketpool-cli/pdao/propose-settings-json_test.go
  • github.com/rocket-pool/smartnode/rocketpool/api/pdao/setting-decode_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Ability to Create Multi-Setting Proposals

1 participant