refactor: establish SVG folder feature - #330
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1b67e4c26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
7 times, most recently
from
August 5, 2026 14:00
b27ff7e to
e269855
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
from
August 5, 2026 14:30
e269855 to
9fae648
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
from
August 5, 2026 14:50
9fae648 to
a283f7e
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
from
August 5, 2026 15:09
a283f7e to
0983cb9
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
from
August 5, 2026 15:45
0983cb9 to
be92aa7
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
from
August 5, 2026 17:40
be92aa7 to
aa45149
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
from
August 6, 2026 14:52
aa45149 to
a57b6d8
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
2 times, most recently
from
August 6, 2026 15:04
ddda867 to
ebfdfed
Compare
jderochervlk
force-pushed
the
codex/option5-svg-folder
branch
from
August 6, 2026 17:19
ebfdfed to
92f4ca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 20 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #329.
Summary
src/svgfolder on the unqualified internalSVGfeatureSVGElement,SVGGraphicsElement, andSVGLengthout of the legacy DOM folderWebAPI.SVG -> WebAPI.DOMNodes + WebAPI.Geometry + SVGfeatureTemporary state
WebAPI.DOMsource entry remains until its remaining interfaces have been assignedSVGElementand will acquire the SVG feature dependency in its later consolidation PRReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,SVGnpm run buildnpm testnpm run format:checkgit diff --check