refactor: establish Geometry folder feature - #324
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2844c280fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
2 times, most recently
from
August 5, 2026 12:14
e945bdc to
7d27d3d
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
2 times, most recently
from
August 5, 2026 12:34
e2d0445 to
e5bfdad
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
from
August 5, 2026 13:40
e5bfdad to
9e4b471
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
from
August 5, 2026 13:57
9e4b471 to
4bcaeb3
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
from
August 5, 2026 14:00
4bcaeb3 to
0d6a001
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
2 times, most recently
from
August 5, 2026 14:50
0b7d177 to
842ab21
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
2 times, most recently
from
August 5, 2026 15:45
0db788f to
3a8fcd9
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
from
August 5, 2026 17:39
3a8fcd9 to
95e4b3b
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
from
August 6, 2026 14:52
95e4b3b to
e28cef7
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
from
August 6, 2026 14:58
e28cef7 to
65b2571
Compare
jderochervlk
force-pushed
the
codex/option5-geometry-folder
branch
from
August 6, 2026 15:04
65b2571 to
18cfe27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 14 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #323.
Summary
src/geometryfolder on the unqualified internalGeometryfeatureWebAPI.Geometryfeature with itsWebAPI.DOMdependencyTemporary state
DOM.*geometry records introduced by the earlier compatibility cleanup; the final cleanup layer will make the owning Geometry modules authoritative after all consumers moveReview focus
WebAPI.Geometry -> WebAPI.DOM + GeometryimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Geometrynpm run buildnpm testnpm run format:checkgit diff --check