refactor: consolidate Messaging folder feature - #322
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0e2ffcefe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 4, 2026 17:31
f0e2ffc to
ffb7185
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
5 times, most recently
from
August 5, 2026 13:57
f29ee5d to
9063620
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
2 times, most recently
from
August 5, 2026 14:30
925443e to
fd1949f
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 5, 2026 14:50
fd1949f to
7a69629
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 5, 2026 15:08
7a69629 to
7c1ada4
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 5, 2026 15:45
7c1ada4 to
5b4b9b8
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 5, 2026 17:39
5b4b9b8 to
1570076
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 6, 2026 14:52
1570076 to
b6282c6
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 6, 2026 14:58
b6282c6 to
68b7fd3
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 6, 2026 15:04
68b7fd3 to
c40ee3f
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 6, 2026 17:19
c40ee3f to
9668d46
Compare
jderochervlk
force-pushed
the
codex/option5-messaging-folder
branch
from
August 6, 2026 20:04
9668d46 to
e6782e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 12 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #321.
Summary
src/messagingfolder on the unqualified internalMessagingfeatureWebAPI.MessagingbundleWebAPI.Messaging -> WebAPI.Event + WebAPI.File + MessagingTemporary state
*Typeshelpers remain inside the correct folder pending final cleanupReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,File,Messagingnpm run buildnpm testnpm run format:checkgit diff --check