Skip to content

refactor: consolidate File folder feature - #320

Open
jderochervlk wants to merge 1 commit into
codex/option5-fetch-folderfrom
codex/option5-file-folder
Open

refactor: consolidate File folder feature#320
jderochervlk wants to merge 1 commit into
codex/option5-fetch-folderfrom
codex/option5-file-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 10 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #319.

Summary

  • rename src/File to the target src/file folder
  • merge the former File and Directory Entries modules into the complete File folder
  • move FileList from the legacy DOM folder into File
  • move BaseFileAndDirectoryEntries out of core and into File
  • remove the separate WebAPI.FileAndDirectoryEntries source feature
  • preserve WebAPI.File -> WebAPI.Event + File and add the merged interfaces to its public module list

Temporary state

  • BaseFile remains in core because DOM.shareData directly references it; moving it here now would create a DOM -> File -> Event -> DOM cycle
  • the final cleanup layer will decide whether to relocate shareData, keep the shared Blob/File records foundational, or introduce a justified slice
  • the internal FileTypes and File and Directory Entries helpers remain inside the correct folder pending cleanup

Review focus

  • complete File folder membership and removal of the extra consumer feature
  • preservation of all flat File and directory-entry public modules
  • the explicit reason for retaining BaseFile in core

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,File
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 5d18c5088d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from 5d18c50 to 9fce765 Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from 9fce765 to 6e042ce Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from 6e042ce to 8096634 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch 2 times, most recently from 4f7ba3c to db2fc5e Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from db2fc5e to 774b854 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch 3 times, most recently from a08ef05 to 22b9fe7 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from 22b9fe7 to 8666177 Compare August 5, 2026 15:08
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from 8666177 to b86a115 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from b86a115 to 2fd0f41 Compare August 5, 2026 17:39
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from 2fd0f41 to d7e6fbc Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from d7e6fbc to b93275f Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-file-folder branch from b93275f to faa1777 Compare August 6, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant