refactor: establish Performance folder feature - #315
Merged
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e21f98c669
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
2 times, most recently
from
August 5, 2026 12:14
8b76c67 to
f6b65e3
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
2 times, most recently
from
August 5, 2026 12:34
03d2b20 to
caf6ea0
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 5, 2026 13:40
caf6ea0 to
440aa6e
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
2 times, most recently
from
August 5, 2026 14:00
4ff8073 to
a31577f
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 5, 2026 14:30
a31577f to
e28bf3d
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 5, 2026 14:50
e28bf3d to
688f0db
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 5, 2026 15:08
688f0db to
64086e5
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 5, 2026 15:45
64086e5 to
ea778f6
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 5, 2026 17:39
ea778f6 to
905960f
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 6, 2026 14:52
905960f to
e9e8a5a
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 13:44
e9a3449 to
7cba01a
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 13:45
7cba01a to
35e1a89
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 13:50
35e1a89 to
d869c0d
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 13:54
d869c0d to
f33e1a3
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 13:56
f33e1a3 to
0f298a9
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 13:57
0f298a9 to
8f54d44
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 13:58
8f54d44 to
11d7d66
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
2 times, most recently
from
August 7, 2026 14:00
ef49fb8 to
1e1ffa5
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 14:00
1e1ffa5 to
461c2d9
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 14:03
461c2d9 to
9bf18c8
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 14:04
9bf18c8 to
f1693f6
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 14:04
f1693f6 to
b6ca8c3
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 14:07
b6ca8c3 to
085104a
Compare
jderochervlk
force-pushed
the
codex/option5-performance-folder
branch
from
August 7, 2026 14:09
085104a to
ade599e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 5 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #314.
Summary
src/Performanceto the targetsrc/performancefolderPerformancefeatureWebAPI.Performancefeature with itsWebAPI.EventdependencyPerformance,PerformanceEntry, andPerformanceMarkpublic modulesThe internal
PerformanceTypeshelper remains private within the complete folder.Temporary state
PerformanceTypesaggregation; type colocation can be handled in the final cleanup after the folder graph is completeReview focus
WebAPI.Performance -> WebAPI.Event + PerformanceimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,Performancenpm run buildnpm testnpm run format:checkgit diff --check