-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: introduce DOMTree compatibility foundation #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** | ||
| Used by the dataset HTML attribute to represent data for custom attributes added to elements. | ||
| [See DOMStringMap on MDN](https://developer.mozilla.org/docs/Web/API/DOMStringMap) | ||
| */ | ||
| type t = private {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /** | ||
| * Compatibility aliases for the recursive DOM interface family. | ||
| * | ||
| * DOMTree and these public type names are permanent; only the aliases below | ||
| * are temporary. PRs #302 through #308 migrate consumers from DOM/DomTypes, | ||
| * then PR #310 replaces the aliases in place with concrete recursive | ||
| * definitions and removes their old DOM/DomTypes definitions. | ||
| */ | ||
| type shadowRootMode = DOM.shadowRootMode | ||
| type slotAssignmentMode = DOM.slotAssignmentMode | ||
| type customStateSet = DOM.customStateSet | ||
|
|
||
| type node = DOM.node | ||
| type element = DOM.element | ||
| type documentFragment = DOM.documentFragment | ||
| type shadowRoot = DOM.shadowRoot | ||
| type htmlElement = DOM.htmlElement | ||
| type htmlFormElement = DOM.htmlFormElement | ||
| type htmlFormControlsCollection = DOM.htmlFormControlsCollection | ||
| type htmlSlotElement = DOM.htmlSlotElement | ||
| type elementInternals = DOM.elementInternals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,25 @@ | ||
| /** | ||
| A generic collection (array-like object similar to arguments) of elements (in document order) and offers methods and properties for selecting from the list. | ||
| [See HTMLCollection on MDN](https://developer.mozilla.org/docs/Web/API/HTMLCollection) | ||
| */ | ||
| type t<'item> = private { | ||
| /** | ||
| Sets or retrieves the number of objects in a collection. | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/HTMLCollection/length) | ||
| */ | ||
| length: int, | ||
| } | ||
|
|
||
| /** | ||
| Retrieves an object from various collections. | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/HTMLCollection/item) | ||
| */ | ||
| @send | ||
| external item: (DomTypes.htmlCollection<'t>, int) => 't = "item" | ||
| external item: (t<'item>, int) => 'item = "item" | ||
|
|
||
| /** | ||
| Retrieves a select object or an object from an options collection. | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/HTMLCollection/namedItem) | ||
| */ | ||
| @send | ||
| external namedItem: (DomTypes.htmlCollection<'t>, string) => 't = "namedItem" | ||
| external namedItem: (t<'item>, string) => 'item = "namedItem" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.