Skip to content

Migrate other styles to PF6 - #259

Merged
keithchong merged 2 commits into
redhat-developer:mainfrom
keithchong:10175-MorePF6Migration
Aug 7, 2026
Merged

Migrate other styles to PF6#259
keithchong merged 2 commits into
redhat-developer:mainfrom
keithchong:10175-MorePF6Migration

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

Migrate remaining styles to PF6

Signed-off-by: Keith Chong <kykchong@redhat.com>
@openshift-ci
openshift-ci Bot requested a review from aali309 August 7, 2026 14:46
@keithchong
keithchong requested a review from aali309 August 7, 2026 14:46
@openshift-ci
openshift-ci Bot requested a review from wtam2018 August 7, 2026 14:46
@keithchong keithchong changed the title Assisted-by: Cursor Grok: Migrate other styles to PF6 Migrate other styles to PF6 Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 032f7415-cd3c-480c-87b9-f8d5a21da7d1

📥 Commits

Reviewing files that changed from the base of the PR and between 7bcb82e and e0eeac0.

📒 Files selected for processing (2)
  • src/gitops/components/project/ProjectSyncWindowsTab.tsx
  • src/gitops/components/shared/ResourceYAMLTab/ResourceYAMLTab.scss
💤 Files with no reviewable changes (1)
  • src/gitops/components/shared/ResourceYAMLTab/ResourceYAMLTab.scss
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/gitops/components/project/ProjectSyncWindowsTab.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated interface styling across application, project, rollout, image updater, and resource views for PatternFly 6 compatibility.
    • Preserved existing table layouts, spacing, text truncation, breadcrumb appearance, and focus behavior.
    • Improved consistency for badges, alignment, empty states, action cells, sync-window displays, and code editor focus states.
    • Refined table headers, column sizing, list spacing, and empty-condition message alignment without changing functionality or displayed data.

Walkthrough

The pull request replaces PatternFly v5 CSS selectors, utility classes, and custom property names with PatternFly v6 equivalents across application, project, rollout, image updater, and shared components.

Changes

PatternFly v6 UI migration

Layer / File(s) Summary
Application and shared selectors
src/gitops/components/application/..., src/gitops/components/shared/..., src/gitops/utils/components/Conditions/Conditions.tsx
Application and shared components now use PatternFly v6 table, breadcrumb, spacing, alignment, code-editor, and history variable selectors.
Project table and utility selectors
src/gitops/components/project/...
Project tabs and table styles now use PatternFly v6 utility, badge, table, button, and text selectors.
Rollout and image updater selectors
src/gitops/components/rollout/..., src/gitops/components/imageupdater/...
Rollout and image updater components now use PatternFly v6 table and spacing selectors.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: wtam2018, aali309

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the migration of remaining GitOps Console Plugin styles to PatternFly 6.
Description check ✅ Passed The description directly states that the remaining styles migrate to PatternFly 6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.30%. Comparing base (01e9db1) to head (e0eeac0).
⚠️ Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
...itops/components/project/ProjectSyncWindowsTab.tsx 0.00% 6 Missing ⚠️
.../gitops/components/project/ProjectAllowDenyTab.tsx 0.00% 1 Missing ⚠️
src/gitops/components/project/ProjectRolesTab.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   11.92%   11.30%   -0.63%     
==========================================
  Files         154      169      +15     
  Lines        6272     6679     +407     
  Branches     2028     2293     +265     
==========================================
+ Hits          748      755       +7     
- Misses       5524     5684     +160     
- Partials        0      240     +240     
Flag Coverage Δ
unit-tests 11.30% <0.00%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Keith, LGTM just minor comments

Comment thread src/gitops/components/project/ProjectSyncWindowsTab.tsx Outdated
Comment thread src/gitops/components/shared/ResourceYAMLTab/ResourceYAMLTab.scss
Signed-off-by: Keith Chong <kykchong@redhat.com>

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithchong
keithchong merged commit 89bc2b8 into redhat-developer:main Aug 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants