Stop using dbcancel as the nogvl unblock function - #607
Open
emailrhoads wants to merge 1 commit into
Open
Conversation
MRI calls the UBF on any pending interrupt (including SIGCHLD on main), which aborted in-flight batches and made Result#each return []. Client :timeout still uses dbsetinterrupt. Co-authored-by: Cursor <cursoragent@cursor.com>
emailrhoads
marked this pull request as draft
August 19, 2026 15:02
emailrhoads
marked this pull request as ready for review
August 19, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rb_thread_call_without_gvlcurrently usesdbcancelas the unblock function. MRI invokes that UBF whenever the waiting thread has a pending interrupt, including process-directed signals such asSIGCHLDdelivered to main after another thread spawns a child.dbcancelthen aborts the in-flight batch.Result#eachtreatsFAILas an empty success, so long queries can return[]even though SQL Server produced rows.NULL, NULL) so other Ruby threads can run, but no longer cancels SQL on those interrupts. Client:timeoutis unchanged (dbsetinterrupt).Timeout.timeout/Thread#killwait until the batch finishes or:timeoutfires.Test plan
WAITFOR DELAY; the followingSELECT 42must still return a row.:timeoutviadbsetinterrupt).