Fix String.prototype.normalize() crash from #1683 - #1688
Merged
Conversation
sr5434
marked this pull request as ready for review
August 23, 2026 23:42
sr5434
changed the title
saghul
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an empty string early in the String.prototype.normalize() method when the string is empty. This prevents an error caused by the first argument of memcpy being a null pointer, as reported in #1683. I added a test to verify that this is fixed.
When I was testing, I could not reproduce the issue on my Mac. However, I successfully reproduced it on a Docker container running ubuntu:24.04.