Skip to content

Add check for QNN_SDK_ROOT in hadamard pass (#21815) - #21815

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D115881389
Aug 13, 2026
Merged

Add check for QNN_SDK_ROOT in hadamard pass (#21815)#21815
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D115881389

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Aug 13, 2026 •
edited by meta-codesync Bot
Loading

Copy link
Copy Markdown
Contributor

Summary:

PR #21729 added HadamardTransform op support, gated on a qnn sdk version. The version check assumed QNN_SDK_ROOT was available, resulting in errors when it is not.

This PR matches other usage like op_embedding.py to fallback when SDK is absent.

Reviewed By: rascani

Differential Revision: D115881389

@pytorch-bot

pytorch-bot Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21815

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3d47926 with merge base dee4fd4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2026
@meta-codesync

meta-codesync Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115881389.

rascani
rascani approved these changes Aug 13, 2026
View reviewed changes

@rascani rascani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@JakeStevens @facebook-github-bot
Add check for QNN_SDK_ROOT in hadamard pass (pytorch#21815)
3d47926 
Summary:

PR  pytorch#21729 added HadamardTransform op support, gated on a qnn sdk version. The version check assumed QNN_SDK_ROOT was available, resulting in errors when it is not.

This PR matches other usage like op_embedding.py to fallback when SDK is absent.

Reviewed By: rascani

Differential Revision: D115881389
@meta-codesync meta-codesync Bot changed the title Add check for QNN_SDK_ROOT in hadamard pass Add check for QNN_SDK_ROOT in hadamard pass (#21815) Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
meta-codesync Bot merged commit 43acee5 into pytorch:main Aug 13, 2026
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rascani rascani rascani approved these changes
@abhinaykukkadapu abhinaykukkadapu Awaiting requested review from abhinaykukkadapu abhinaykukkadapu is a code owner
@psiddh psiddh Awaiting requested review from psiddh psiddh is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JakeStevens @rascani