Skip to content

[docker] Add return types for secret model operations - #16185

Open
Mohith1612 wants to merge 1 commit into
python:mainfrom
Mohith1612:agent/improve-docker-secret-return-types
Open

[docker] Add return types for secret model operations#16185
Mohith1612 wants to merge 1 commit into
python:mainfrom
Mohith1612:agent/improve-docker-secret-return-types

Conversation

@Mohith1612

@Mohith1612 Mohith1612 commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Secret.name, Secret.remove, SecretCollection.create, and
SecretCollection.get currently have implicit Any return types even though
docker-py 7.2.0 has unambiguous implementations:

This adds the corresponding str, bool, and Secret return annotations.

Agent used: Codex was used for reconnaissance, implementation, and review.

@Mohith1612
Mohith1612 marked this pull request as ready for review August 11, 2026 17:43
donbarbos
donbarbos approved these changes Aug 11, 2026
View reviewed changes

@donbarbos donbarbos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@donbarbos donbarbos donbarbos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mohith1612 @donbarbos