gh-110941: Fix json.dump encoding dict subclasses as empty. - #111036
Open
aljungberg wants to merge 6 commits into
Open
gh-110941: Fix json.dump encoding dict subclasses as empty.#111036aljungberg wants to merge 6 commits into
json.dump encoding dict subclasses as empty.#111036aljungberg wants to merge 6 commits into
Conversation
See python#110941 for full details but the tldr is that the C optimised JSON encoder did not handle `dict` subclasses correctly and encoded them as empty if they did not put something into `super()`'s storage.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
eendebakpt
reviewed
Nov 10, 2023
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
eendebakpt
approved these changes
Jan 15, 2024
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
|
@aljungberg Could you rebase the PR onto current main? I will then ping one of the devs to review |
github-actions
Bot
removed
the
stale
# Conflicts: # Modules/_json.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #110941 for full details but the tldr is that the C optimised JSON encoder did not handle
dictsubclasses correctly and encoded them as empty if they did not put something intosuper()'s storage.json.dumpsaccesses dict internals even for dict subclasses #110941