Correct column names in logical record 0500 in get/read_bsrn - #2841
Open
AdamRJensen wants to merge 4 commits into
Open
Correct column names in logical record 0500 in get/read_bsrn#2841AdamRJensen wants to merge 4 commits into
AdamRJensen wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR fixes a bug in the column naming when requesting logical record 0500 data with the get/read_bsrn functions.
Specifically, the first two columns on the second lines in LR0500 do not contain any data and hence these two columns should be removed. Additionally, the first row lines do not contain data in the last four columns. Therefore, there needs to be six consequetive columns removed after unpacking the data. These columns are first named "empty" and then subsequently removd.