Skip to content

Correct column names in logical record 0500 in get/read_bsrn - #2841

Open
AdamRJensen wants to merge 4 commits into
pvlib:mainfrom
AdamRJensen:fix-bsrn-lr0500
Open

Correct column names in logical record 0500 in get/read_bsrn#2841
AdamRJensen wants to merge 4 commits into
pvlib:mainfrom
AdamRJensen:fix-bsrn-lr0500

Conversation

@AdamRJensen

@AdamRJensen AdamRJensen commented Aug 5, 2026

Copy link
Copy Markdown
Member
  • Closes Issue in get/read_bsrn naming of variables in logical record 0500 #2835
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR fixes a bug in the column naming when requesting logical record 0500 data with the get/read_bsrn functions.

Specifically, the first two columns on the second lines in LR0500 do not contain any data and hence these two columns should be removed. Additionally, the first row lines do not contain data in the last four columns. Therefore, there needs to be six consequetive columns removed after unpacking the data. These columns are first named "empty" and then subsequently removd.

@AdamRJensen AdamRJensen added this to the v0.16.0 milestone Aug 5, 2026
@AdamRJensen AdamRJensen added the remote-data triggers --remote-data pytests label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug io remote-data triggers --remote-data pytests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue in get/read_bsrn naming of variables in logical record 0500

1 participant