Add support for iam.schlick to ModelChain - #2832
Open
cbcrespo wants to merge 4 commits into
Open
Conversation
cwhanse
reviewed
Jul 23, 2026
Member
|
@cbcrespo Given Anton's comment here I think we should also add a warning to the function itself (an admonition) stating something along the lines of:
|
RDaxini
reviewed
Aug 5, 2026
RDaxini
left a comment
RDaxini
left a comment
Member
There was a problem hiding this comment.
LGTM, just a note on pvsystem.py and the whatnsew. #2832 (comment) should also be addressed and then I think this PR is ready to go.
|
|
||
| iam_model : string, default 'physical' | ||
| The IAM model to be used. Valid strings are 'physical', 'ashrae', | ||
| 'martin_ruiz', 'sapm' and 'interp'. |
Member
There was a problem hiding this comment.
I think we need to update the docstring here too to include schlick
Suggested change
| 'martin_ruiz', 'sapm', 'interp', and 'schlick'. |
| * Karl Hill (:ghuser:`karlhillx`) | ||
| * Mathias Aschwanden (:ghuser:`maschwanden`) | ||
| * Yonry Zhu (:ghuser:`yonryzhu`) | ||
| * Darshan Gowda (:ghuser:`dgowdaan-cmyk`) |
Member
There was a problem hiding this comment.
don't forget this! thanks for your ongoing contributions
Suggested change
| * Darshan Gowda (:ghuser:`dgowdaan-cmyk`) | |
| * Darshan Gowda (:ghuser:`dgowdaan-cmyk`) | |
| * Carolina Crespo (:ghuser:cbcrespo) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iam.schlicktoModelChain#2828Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Currently, all direct IAM models available in
pvlib.iamare supported byModelChainexcept forschlick. This PR adds support forschlick.