fix: F-2026-18139 | [Dual Defense] Cross-RPC Height Skew Can Underflow Confirmation Counts and Prematurely Finalize Inbounds - #302
Open
Aman035 wants to merge 4 commits into
Open
fix: F-2026-18139 | [Dual Defense] Cross-RPC Height Skew Can Underflow Confirmation Counts and Prematurely Finalize Inbounds#302Aman035 wants to merge 4 commits into
Aman035 wants to merge 4 commits into
Conversation
…irmation instant routes to testnet (F-2026-18139)
Member
Author
|
Rejecting zero values in registry validation - @0xNilesh I believe uregistry should also have this check as mentioned in recommendation guarded by testnet & mainnet configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.ConfirmationDepth(latest, tx). When the latest height is behind the tx height (cross-RPC skew), both EVM and SVM confirmers defer the event (keep it PENDING and log at debug) instead of confirming on an underflowed depth.uint64 >= 0fallback and moved the registry-zero decision intoapplyDefaults.push_networkconfig flag. On testnet a registry depth of 0 is honored as an instant route; on mainnet it falls back to a safe depth (fast 5, standard 12). Unset is treated as mainnet.GetTransactionnow pinsCommitmentFinalizedexplicitly.Where our approach differs from the recommendation
>= 0to> 0. We deleted the fallback instead and gated zero behindpush_network, because zero is now a valid, explicit mode (testnet instant routes) rather than always a misconfiguration. The intent - never silently run at zero on mainnet is fully met.