(MODULES-11902) Include puppet 8.0.0 and do a release for puppetlabs-sqlserver - #506
Open
SugatD wants to merge 2 commits into
Open
(MODULES-11902) Include puppet 8.0.0 and do a release for puppetlabs-sqlserver#506SugatD wants to merge 2 commits into
SugatD wants to merge 2 commits into
Conversation
3 tasks
Member
|
@SugatD : This is blocking tests from being able to run. Is there anything blocking us from moving forward with this? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>8.0.0 < 9.0.0) in PR (CAT-2393) Puppetcore update #492, excluding the 8.0.0 release itself. Correctedmetadata.jsonrequirements to>=8.0.0 < 9.0.0so puppet 8.0.0 is included.dependency-checkerstep was failing becausepuppetlabs/stdlibreleased10.0.1, which fell outside the module's declared upper bound (< 10.0.0). Widened thepuppetlabs/stdlibdependency requirement to>= 8.4.0 < 11.0.0to include current stdlib releases.Checklist
Notes
Windows-*, puppetcore8-nightlyacceptance checks fail, but this is a pre-existing, unrelated infrastructure issue (also fails on PR (MODULES-11838) Update link to Puppet modules contributing documentation #504, merged before this change): the third-partypuppet_agentmodule's bootstrap manifest references the unsupported top-scope fact::osfamilyagainst Puppet 8.Jira: https://perforce.atlassian.net/browse/MODULES-11902