[PR #623]: Acceptance Test PR - Add support for Ubuntu 26.04 - #628
[PR #623]: Acceptance Test PR - Add support for Ubuntu 26.04#628span786 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds module support for Ubuntu 26.04 by updating the default OpenJDK selection logic and extending unit test coverage to validate the expected package/JAVA_HOME behavior across supported Ubuntu releases.
Changes:
- Updated Debian-family release-to-OpenJDK mapping to default Ubuntu 26.04 to OpenJDK 21.
- Added Ubuntu 26.04 to the module’s supported OS list in
metadata.json. - Expanded
javaclass spec coverage for Ubuntu 18.04/20.04/22.04 (OpenJDK 11) and added explicit specs for Ubuntu 24.04 (OpenJDK 17) and 26.04 (OpenJDK 21).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/classes/java_spec.rb | Extends rspec-puppet coverage for Ubuntu releases and expected OpenJDK/JAVA_HOME values. |
| metadata.json | Declares Ubuntu 26.04 as a supported OS release. |
| manifests/params.pp | Maps Ubuntu 26.04 to OpenJDK 21 defaults in Debian-family params logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The original PR #623 for this has been closed by the contributor, but they still are interested in the fix. They have suggested (via a Slack conversation) that we continue by using this PR for further changes that are required. I will update this branch to pick up the latest changes and see if we can get acceptance tests running against 26.04. |
Set default OpenJDK to 21 for Ubuntu 26.04 in params.pp Add Ubuntu 26.04 to supported OS releases in metadata.json Extend parameterized tests for Ubuntu 18.04 to include 20.04 and 22.04 (openjdk-11) Add separate tests for Ubuntu 24.04 (openjdk-17) and 26.04 (openjdk-21)
967f130 to
b966086
Compare
|
The acceptance tests ran cleanly, but they are still not running against Ubuntu 26.04: This requires the testing infra team to fix so we can provision the testing environment. |
Summary
Set default OpenJDK to 21 for Ubuntu 26.04 in params.pp Add Ubuntu 26.04 to supported OS releases in metadata.json Extend parameterized tests for Ubuntu 18.04 to include 20.04 and 22.04 (openjdk-11) Add separate tests for Ubuntu 24.04 (openjdk-17) and 26.04 (openjdk-21)
Related Issues (if any)
PR #623
Checklist
puppet apply)