Enable RHSM certguard tests under domains - #7964
Draft
dralley wants to merge 1 commit into
Draft
Conversation
mdellweg
reviewed
Aug 13, 2026
Comment on lines
-29
to
-31
| if settings.DOMAIN_ENABLED: | ||
| pytest.skip("RHSM tests are currently not compatible with domains.", allow_module_level=True) | ||
|
|
Member
There was a problem hiding this comment.
Do you happen to know why? We forgot to help ourselves back then...
Is it because we test with rhsm entitlements that do not have domains in their paths?
Contributor
Author
There was a problem hiding this comment.
Something like that. I think permit() needs a fix also perhaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough