Fix panic in poll_for_sketch_updates when message system not initialized - #218
Open
pepc84 wants to merge 1 commit into
Open
Fix panic in poll_for_sketch_updates when message system not initialized#218pepc84 wants to merge 1 commit into
pepc84 wants to merge 1 commit into
Conversation
sketch_update_handler uses MessageReader<AssetEvent<Sketch>> which requires
Bevy's message system to be initialized. When called via run_system_cached
before the app is fully started, it returns SystemParamValidationError
instead of a value, causing unwrap() to panic.
Fix: use .ok().flatten() to return None gracefully when the system
isn't ready, matching the expected Option<Sketch> return type.
Fixes: thread panicked at crates/processing_render/src/lib.rs
called Result::unwrap() on Err(Failed(SystemParamValidationError {
message: "Message not initialized", field: "::messages" }))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sketch_update_handler uses MessageReader<AssetEvent> which requires Bevy's message system to be initialized. When called via run_system_cached before the app is fully started, it returns SystemParamValidationError instead of a value, causing unwrap() to panic.
Fix: use .ok().flatten() to return None gracefully when the system isn't ready, matching the expected Option return type.
Fixes: thread panicked at crates/processing_render/src/lib.rs
called Result::unwrap() on Err(Failed(SystemParamValidationError {
message: "Message not initialized", field: "::messages" }))