Add StrictDecoding trait - #489
Merged
Merged
Conversation
Adopts strict decoding introduced in StructuredQueries, ensuring that type mismatches are better caught. By default, decoding is lenient but will begin to emit runtime warnings so that developers can resolve existing issues in their code base. Once migrated, folks can enable the `StrictDecoding` trait for harder failure, and in a 2.0 major release strict decoding will likely be the default.
* use typed throws in SQLite query/function decoder This prevents an allocation, particularly on type mismatch, improving performance for columns containing multiple data types. * Refactor date decoding logic in SQLiteFunctionDecoder * Fix date decoding logic in SQLiteQueryDecoder --------- Co-authored-by: Stephen Celis <stephen.celis@gmail.com> Co-authored-by: Stephen Celis <stephen@stephencelis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts strict decoding introduced in StructuredQueries, ensuring that type mismatches are better caught. By default, decoding is lenient but will begin to emit runtime warnings so that developers can resolve existing issues in their code base. Once migrated, folks can enable the
StrictDecodingtrait for harder failure, and in a 2.0 major release strict decoding will likely be the default.