Manage dashboard access rights per Group and per User - #144
Open
MichaelRodriguesOficial wants to merge 6 commits into
Open
Manage dashboard access rights per Group and per User#144MichaelRodriguesOficial wants to merge 6 commits into
MichaelRodriguesOficial wants to merge 6 commits into
Conversation
stonebuzz
requested changes
Jul 17, 2026
| * | ||
| * @return bool | ||
| */ | ||
| public function showRightsForm($itemtype, $itemsId, $options = []) |
Contributor
There was a problem hiding this comment.
You should use Twig templates instead.
Direct echo statements in PHP are no longer allowed. All output should be rendered through Twig templates to comply with the current coding standards.
There was a problem hiding this comment.
Thanks for the review! You are absolutely right. I will refactor the showRightsForm() method to use Twig templates, following current GLPI standards.
Contributor
There was a problem hiding this comment.
You should use Twig to eliminate all the echo statements
Rom1-B
requested changes
Jul 22, 2026
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Rom1-B
requested changes
Aug 7, 2026
| * | ||
| * @return bool | ||
| */ | ||
| public function showRightsForm($itemtype, $itemsId, $options = []) |
Contributor
There was a problem hiding this comment.
You should use Twig to eliminate all the echo statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to better manage access to the dashboards.
Checklist before requesting a review
Description
Currently, dashboard access can only be granted per Profile. This PR adds the ability to also grant (or deny) access per Group and per User, using the same rights mechanism (
Profile::dropdownRight) already used for profiles.PluginMetabaseItemrightclass, mirroringPluginMetabaseProfileright, storing rights keyed byitemtype(GrouporUser) +items_id+dashboard_uuid.group/userUPDATE rights, to manage dashboard access for that group/user.I did not add automated tests since the plugin doesn't currently have a test suite in place.
Screenshots: