Fix thread safety of lazy graph object properties - #5691
Open
hb1915 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #3441
Description of change
Make lazy initialization of compound graph-object properties safe for concurrent first reads. Concurrent readers now converge on the first child or child list published to the cache, preventing a later initializer from orphaning objects already returned to another thread.
Demo
Not applicable; this fixes an intermittent server-side exception without changing rendered figures.
Testing strategy
Added a deterministic two-thread regression test for both compound and compound-array properties. The test forces the failing interleaving: it fails on unpatched
mainwith distinct compound children andValueError("Invalid value")for the compound array, then passes with this change.Validation performed:
python -m pytest tests/test_core -q— 456 passed, 1 skippedAdditional information (optional)
The cache still permits duplicate construction during a concurrent cold read, but
dict.setdefaultmakes publication single-winner so all readers receive objects that remain attached to their parent. This avoids adding a lock to every graph object and its associated memory, re-entrancy, deepcopy, and pickling considerations.Guidelines