Skip to content

Send isNavigationRequest in the route request payload - #124

Open
kbond wants to merge 1 commit into
playwright-php:mainfrom
kbond:send-is-navigation-request
Open

Send isNavigationRequest in the route request payload#124
kbond wants to merge 1 commit into
playwright-php:mainfrom
kbond:send-is-navigation-request

Conversation

@kbond

@kbond kbond commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Request::isNavigationRequest() always returns false. It reads $this->data['isNavigationRequest'] ?? false, but serializeRequest() in bin/playwright-server.js never includes the field, so the default is all any caller ever sees.

Added it to the payload alongside resourceType, using the same defensive req.isNavigationRequest ? ... : false shape as the neighbouring properties.

Verified against a route handler on a page with a subresource: the document request now reports true and a stylesheet request reports false (both reported false before).

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant