Walk closure by-ref convergence passes in deep statement context - #6208
Merged
Conversation
The closure by-ref fixpoint walked its intermediate passes with a top-level statement context, so every inner loop re-converged from scratch on every pass - convergence within convergence, which the loop handlers themselves avoid by walking their passes with enterDeep(). A recursive by-ref closure with nested loops re-created the innermost expressions' results many times over; deep-context passes bring it in line with the loop handlers' discipline, and the final top-level walk keeps full precision. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closure by-ref fixpoint walked its intermediate passes with a top-level statement context, so every inner loop re-converged from scratch on every pass — convergence within convergence, which the loop handlers themselves avoid by walking their intermediate passes deep. A by-ref closure with nested loops re-created the innermost expressions' results many times over; deep-context passes bring it in line with the loop handlers' discipline, and the final top-level walk keeps full precision.
Zero expectation churn: full test suite green in both turbo modes, self-analysis and CS clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7