ext/curl: abort curl transfer if callback throws exception - #22745
Merged
Conversation
Contributor
Author
|
@cmb69 Could you review this? |
Sjord
commented
Jul 21, 2026
Contributor
Author
|
@eyupcanakman Could you take a look at this? |
Sjord
force-pushed
the
curl-abort-on-exception
branch
from
July 27, 2026 09:28
9d664cb to
5f7cf70
Compare
This did not raise an error before, so return OK. I didn't add a test for curl_prereqfunction because this is already tested in curl_setopt_CURLOPT_PREREQFUNCTION.phpt. I marked some callbacks being null as unexpected, where I didn't find any code that set them to null in sourcegraph. Specifically, guzzle sets header, read, write and progress to null, so maybe this is not so unexpected.
Sjord
changed the title
Contributor
Author
|
@Ayesh Could you take a look at this? |
Girgias
reviewed
Aug 7, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Minor nits but looks sensible.
If return value is undefined, it's always an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves bug #16513
Also includes #16790