Added readonly reinitable helper - #22718
Merged
Merged
Conversation
AWS x86_64 (c6id.metal)
Laravel 12.11.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Symfony 2.8.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Wordpress 6.9 main page - 50 iterations, 20 warmups, 20 requests (sec)
bench.php - 50 iterations, 20 warmups, 2 requests (sec)
|
NickSdot
force-pushed
the
readonly-reinitable-helper
branch
from
August 7, 2026 16:42
41991ab to
c952aec
Compare
Girgias
reviewed
Aug 7, 2026
Girgias
left a comment
Member
There was a problem hiding this comment.
Does this API need to be exposed? I'd prefer this to be static to reduce the API surface of the engine.
Contributor
Author
Yes, because #22588 (RFC passed) is calling it from https://github.com/php/php-src/pull/22588/changes#diff-22314cb41b89cd823c95f1073b63956a80c293a1bb4bcc95d5b05d2388f75e3dR305 |
Girgias
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #22654 as discussed in #22588 (comment).
Added
zend_object_set_properties_reinitable()to centralise temporarily allowing reinitialisation of initialised readonly properties during controlled operations such as cloning and unserialisation.cc @TimWolla